[transferwebhooks] Code generation: update services and models #1620
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers an automated update to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request, generated automatically, updates services and models for transferwebhooks. However, a critical issue has been introduced in transferDataTracking.ts. The mapping property, which is essential for deserializing discriminated union types, has been set to undefined. This will break webhook processing. I've provided a suggestion to restore the mapping and fix this issue.
| "estimation": "EstimationTrackingData", | ||
| "internalReview": "InternalReviewTrackingData" | ||
| }; | ||
| static readonly mapping: {[index: string]: string} | undefined = undefined; |
There was a problem hiding this comment.
Removing the mapping from TransferDataTrackingClass will break the deserialization of the TransferDataTracking union type. The ObjectSerializer relies on this mapping to instantiate the correct class (e.g., ConfirmationTrackingData, EstimationTrackingData) based on the value of the type discriminator field. Without this mapping, the tracking property in webhooks will be deserialized as a plain object instead of an instance of the correct class. This will likely cause the test should correctly deserialize union types in transfer webhooks to fail and lead to runtime errors.
static readonly mapping: {[index: string]: string} = {
"confirmation": "ConfirmationTrackingData",
"estimation": "EstimationTrackingData",
"internalReview": "InternalReviewTrackingData"
};
AdyenAutomationBot
force-pushed
the
sdk-automation/transferwebhooks
branch
from
869bc8c to
6afbeee
Compare
AdyenAutomationBot
force-pushed
the
sdk-automation/transferwebhooks
branch
from
6afbeee to
41b47a0
Compare
This PR contains the automated changes for the
transferwebhooksservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.